fix: should ensure can access all decorators from app built with helper.build
#742
Conversation
|
I really need this fix merged in 😊 |
jean-michelet
changed the title
helper.buildhelper.build
Next time, feel free to push a PR with unit tests. We'd be happy to review your code and merge the fixes. |
| const appFn = file.default || file | ||
| const appPlugin = appConfig.skipOverride ? fp(appFn) : appFn | ||
| await fastify.register(appPlugin, appConfig) |
There was a problem hiding this comment.
I am not sure it's possible to reset the fp wrapping without breaking the existing. We can allow a skipOverride option here. On the other hand, I don't know if it's a good idea to pass it in additionalOptions, if a user is using a skipOverride option that does something different in the app, it could be an unexpected side effect, right? Altough seems very unlikely.
I can avoid this with a destructuration:
const { skipOverride, ...config } = appConfig
await fastify.register(appPlugin, config)We can also pass a fourth argument to runFastify, but it seems a bit overkill.
Any suggestion?
|
Even if I've already pushed a PR, if the tests are broken and you have the right solution, that's OK to push a new PR or to tell me why my PR is wrong and how I can fix it. Fastify is community driven, so maintainers don't usually solve bugs for you. I left you this message to save you time, not to lecture you, just to be clear ^^ |
I don't understand what you are talking about, I saw that there is a PR open for this feature/issue, and I am merely expressing my interest for this being completed, personally I love it when users express their need for specific issues being fixed to help with triage. To each their own I guess. edit: just saw the merge, thank you very much 👍 |
Fixes #622